Skip to content

Conversation

wonderfulShrineMaidenOfParadise
Copy link

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise commented Jul 28, 2025

img: add app-dark.svg

Dark version of app.svg from 18615eb

Alt Text

OCA\Passman\Notifier: setIcon()

Set the icon for the notification.

0

OCA\Passman\Settings: add AdminSection

Also rename the section from additional to passman.

1

Dark version of app.svg from 18615eb

Signed-off-by: Raymond Hackley <[email protected]>
Set the icon for the notification.

Signed-off-by: Raymond Hackley <[email protected]>
Also rename the section from 'additional' to 'passman'.

Signed-off-by: Raymond Hackley <[email protected]>
@binsky08
Copy link
Collaborator

thanks for the pr, it looks quite interesting. I'll try to check it out soon^TM

@binsky08 binsky08 added this to the next milestone Sep 26, 2025
Copy link
Collaborator

@binsky08 binsky08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a technical perspective I'm fine with it, already tested it and it works well. Thanks @wonderfulShrineMaidenOfParadise .

I am not sure about the new Passman settings section. Personally I like it, but the documentation says:

It is also possible that an app registers its own section. This should be done only if there is no fitting corresponding section and the app’s settings form takes a lot of screen estate. Otherwise, register to “additional”.

and well, our settings does not take "a lot of screen estate" and fits well in “additional”.
On the other hand, it would simplify finding the Passman settings at all.

@animalillo what would you say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants