Limit the delay for an update to "in one day" #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grotax
force-pushed
the
updater/adjustments
branch
2 times, most recently
from
9ca0bfd to
d45ee0b
Compare
|
I'm not sure if this had the desired effect since the result for my test feed has changed, I need to check the feed again and think about it. |
Grotax
force-pushed
the
updater/adjustments
branch
from
e4a00a9 to
993d739
Compare
…e calculation Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
force-pushed
the
updater/adjustments
branch
from
993d739 to
73eb5af
Compare
Signed-off-by: Benjamin Brahmer <[email protected]>
wofferl
reviewed
Jan 2, 2025
wofferl
approved these changes
Jan 2, 2025
Grotax
added a commit
that referenced
this pull request
Jan 2, 2025
Changed - Set maximum delay for updates to "in one day" (#3015) - add an information list for feeds that displays data such as last or next update dates (#3021) Fixed - OPML import use text field for title if title field is missing (#3016) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Jan 2, 2025
Changed - Set maximum delay for updates to "in one day" (#3015) - add an information list for feeds that displays data such as last or next update dates (#3021) Fixed - OPML import use text field for title if title field is missing (#3016) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The calculations feed-io does can lead to high values that would delay the next update for too long.
Maybe the calculations done in feed-io could be improved but this provides a simple fix by limiting the delay to maximum one day.
Adds SLEEPY_DURATION to FetcherConfig and use it for the nextUpdateTime calculation.
#3013
Checklist