Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SSO Lib from 1.1.0 -> 1.3.2 #1473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

David-Development
Copy link
Member

No description provided.

@David-Development
Copy link
Member Author

@tobiasKaminsky @stefan-niedermann I noticed that the API for the verifyMinVersion changed but in the corresponding MR I couldn't really find the motivation behind it nextcloud/Android-SingleSignOn#735.

What was the reason for the change? The docs contain an invalid example on how to use the API and I'm not sure if the changes in this MR are correct according to how I am supposed to use the API 😅

@stefan-niedermann
Copy link
Member

Hey @David-Development 👋
Background of the changes in the SSO lib was to be able to connect to branded Nextcloud files clients which use different account IDs. This was not possible until now without forking the SSO lib and adjusting the EFilesAppType enum, now the target Files App Type ID can be set by the 3rd party app in Application#onCreate dynamically.

While the changes have been implemented by @tobiasKaminsky I needed tsuch a feature personally too, so I support the changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants