Skip to content

feat: add delegation frontend#12698

Open
hamza221 wants to merge 1 commit intomainfrom
feat/delegation-frontend
Open

feat: add delegation frontend#12698
hamza221 wants to merge 1 commit intomainfrom
feat/delegation-frontend

Conversation

@hamza221
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 commented Apr 6, 2026

STATUS: I'll wait for the backend to get merged before continuing with this

requires #12605
ref #12403

1 2 3 4
image image image image
image
  • Design review
  • hide action on delegated accounts

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the feat/delegation-frontend branch from 3831f1a to 2afc85a Compare April 6, 2026 13:05
@hamza221 hamza221 changed the title feat: add delegation backend feat: add delegation frontend Apr 6, 2026
@hamza221 hamza221 requested a review from nimishavijay April 6, 2026 13:14
@hamza221 hamza221 self-assigned this Apr 6, 2026
@hamza221 hamza221 mentioned this pull request Apr 6, 2026
2 tasks
@hamza221 hamza221 requested a review from kra-mo April 6, 2026 13:17
@hamza221 hamza221 marked this pull request as ready for review April 6, 2026 15:28
Copy link
Copy Markdown
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks really nice! Only some small changes. Overall:

  • The icon for delegation (across the board) can be supervisor account. The one you've chosen is also very similar but we use that for indicating users and groups
  • Instead of "Delegation", I'm wondering if we can use the wording "Delegate account" in the 3 dot menu and the modal title
  • Use tertiary buttons for all the "Cancel" buttons and don't use the icon.

In the "Delegation" modal:

  • There is some whitespace on top which shouldn't be there (somewhow not there in the "Add delegates" modal)
  • We can also center align the "Delegates" heading. Ik in @kra-mo's mockups it was left aligned, but because in the component we always have the heading in the center it looks inconsistent now.
  • I see that there's a h3 { font-weight: bold; } which makes the "Delegates" heading stronger than its parent heading. We could remove that

In the "Add delegates" modal:

  • the select component should be full width

@kra-mo
Copy link
Copy Markdown
Member

kra-mo commented Apr 7, 2026

We can also center align the "Delegates" heading.

I was going off of form group components, not a dialog, in this context, I think the two different headings don't make sense either, we could just have one "Delegates" title :)

Copy link
Copy Markdown
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding to what @nimishavijay said, the "Revoke" button should also probably not have an icon, a checkmark with danger styling is always confusing :)

Additionally, the user selection dropdown should be full-width and there should be a bit more padding between the explanation text beneath and the buttons, also in the revoke access dialog.

@hamza221 hamza221 mentioned this pull request Apr 13, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants