chore: PR Checklist #10891
Open
chore: PR Checklist #10891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
| * Requires: #… | ||
| * Resolves: #… | ||
|
|
||
| * Backport to… |
There was a problem hiding this comment.
this will be done in comments anyway -> duplicates information -> drop it
Comment on lines
+28
to
+83
| ## 🖌️ Front End Checklist | ||
|
|
||
| ### Summary | ||
|
|
||
| Please give a brief summary of the front end changes | ||
|
|
||
| ### 🖼️ Screenshots / Screencasts | ||
|
|
||
| 🏚️ Before | 🏡 After | ||
| -- | -- | ||
| Screenshot before | Screenshot after | ||
|
|
||
| <!-- ☀️ Light theme | 🌑 Dark Theme --> | ||
|
|
||
| ### 🚧 Tasks | ||
|
|
||
| - [ ] ... | ||
|
|
||
| ### 🏁 Checklist | ||
|
|
||
| | ❌ | ✅ | Task | | ||
| |----|----|-----| | ||
| | [ ] | [ ] | 🌏 Tested with different browsers / clients: | ||
| | | [ ] | Chromium (Chrome / Edge / Opera / Brave) | ||
| | | [ ] | Firefox | ||
| | | [ ] | Safari | ||
| | | [ ] | Not risky to browser differences / client | ||
| | [ ] | [ ] | 🖌️ Design was reviewed, approved or inspired by the design team | ||
| | [ ] | [ ] | ⛑️ Tests (unit and/or integration) | ||
| | [ ] | [ ] | 📗 Admin documentation in https://github.com/nextcloud/documentation/tree/master/admin_manual/groupware | ||
| | [ ] | [ ] | 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/groupware | ||
|
|
||
| <!-- | ||
| Feel free to remove this section when your PR is only touching frontend/UI code | ||
| --> | ||
|
|
||
| --- | ||
|
|
||
| ## 🛠️ Back End Checklist | ||
|
|
||
| ### Summary | ||
|
|
||
| Please give a brief summary of the back end changes | ||
|
|
||
| ### 🚧 Tasks | ||
|
|
||
| - [ ] ... | ||
|
|
||
| ### 🏁 Checklist | ||
|
|
||
| | ❌ | ✅ | Task | | ||
| |----|----|-----| | ||
| | [ ] | [ ] | ⛑️ Tests (unit and/or integration) | ||
| | [ ] | [ ] | 📗 Admin documentation in https://github.com/nextcloud/documentation/tree/master/admin_manual/groupware | ||
| | [ ] | [ ] | 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/groupware | ||
| | [ ] | [ ] | 📘 Developer documentation in https://github.com/nextcloud/documentation/tree/master/developer_manual |
There was a problem hiding this comment.
IMO this is asking too much, which will tend to make people ignore the template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a PR check list