EnvelopeSkeleton: add filler on hover to prevent text shifting #10583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GVodyanov
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
GretaD
reviewed
Feb 4, 2025
GVodyanov
force-pushed
the
style/fix-envelope-text-shifting
branch
from
c247975 to
11d126c
Compare
|
i tested it again, for in me all screen sizes it jumps like this. Screencast.from.2025-04-29.14-20-04.mp4 |
|
Found the issue! Thanks a lot @GretaD |
Signed-off-by: Grigory Vodyanov <[email protected]>
GVodyanov
force-pushed
the
style/fix-envelope-text-shifting
branch
from
8150153 to
a267f4f
Compare
ChristophWurst
approved these changes
May 13, 2025
There was a problem hiding this comment.
Looks sane. @GretaD please test if the flickering is fixed for you as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 1/2 #10561
When hovering on envelopes in the envelope list, the preview text shouldn't expand when date is hidden