-
-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #3184: Download Limit Support #3204
Conversation
This depends on the still pending merge request for required changes in NextcloudKit (nextcloud/NextcloudKit#107). Given that is integrated and released as a version, the dependency version specification in this merge request must be adjusted before merging. |
f6886b2
to
33b840f
Compare
33b840f
to
6e07bc0
Compare
- Added tableDownloadLimit entity to app database. - Extended capability query to also consider download limit app. - Extended capabilities list view for display of download limit availability. - Extended share detail user interface to mimic the web user interface for managing download limits. - Every time WebDAV properties of a file are retrieved, its associated download limits are removed and recreated. Housekeeping: - Outsourced NCShareDateCell into dedicated source code file. - Outsourced NCShareToggleCell into dedicated source code file. Notes: - In my first attempt I had a detail view in the download limit row of the advanced share options showing the remaining number of downloads. However, that required to inject and retain the download limit entity object into the complicated share table configuration object. That, in turn, results in inconsistent data state due to invalid and outdated references. To resolve those issues, the assembly of the advanced share options user interface needs some refactoring which appears to expansive at this point and I prefer to leave it as it is for now. Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
6e07bc0
to
1965c6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev I have enabled those already. That's one of the first things I always do when setting up Xcode. 😁 But for some reason Xcode really likes its white space lines… 🙄
I first had an accessory view in the share view but I remember faintly it somehow spaghettified state management, so I left it out. I will have another look into it. |
@mpivchev Now I remember what the problem was. It worked only partially due to the complicated |
Signed-off-by: Iva Horn <[email protected]>
Housekeeping:
Notes: