Skip to content

Replace IConfig by IUserConfig#59

Merged
julien-nc merged 4 commits into
mainfrom
enh/noid/iuserconfig
Mar 23, 2026
Merged

Replace IConfig by IUserConfig#59
julien-nc merged 4 commits into
mainfrom
enh/noid/iuserconfig

Conversation

@julien-nc
Copy link
Copy Markdown
Member

@julien-nc julien-nc commented Mar 23, 2026 •
edited
Loading

  • bump supported nc version to 33->34
  • use new IUserConfig over deprecated IConfig (no lazy values as they are accessed quite often)
  • use phpunit 13
  • use php 8.4 in tests (it's ok because there is only dev dependencies and tests are integration ones)

@julien-nc
bump supported nc version to 33->34, replace IConfig by IUserConfig
9cb9dcf 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
use phpunit 13
649872e 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/iuserconfig branch 5 times, most recently from 63c6db3 to 5f9f92c Compare March 23, 2026 14:32
@julien-nc
use php 8.2 in psalm config and 8.4 in tests
5f9e5da 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
display phpunit deprecations, warnings and notices
f5c3b52 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/iuserconfig branch from 5f9f92c to f5c3b52 Compare March 23, 2026 14:35
@julien-nc julien-nc marked this pull request as ready for review March 23, 2026 14:37
@julien-nc julien-nc requested a review from marcelklehr as a code owner March 23, 2026 14:37
@julien-nc julien-nc merged commit 14eea08 into main Mar 23, 2026
8 checks passed
@julien-nc julien-nc mentioned this pull request Mar 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr Awaiting requested review from marcelklehr marcelklehr is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@julien-nc