Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Constant is undefined #1868

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Fix Constant is undefined #1868

merged 1 commit into from
Jan 11, 2022

Conversation

CarlSchwan
Copy link
Member

Fix #1867

@CarlSchwan
Fix Constant is undefined
7a5f263 
Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan added the 3. to review Items that need to be reviewed label Jan 11, 2022
@CarlSchwan CarlSchwan mentioned this pull request Jan 11, 2022
Closed
@CarlSchwan CarlSchwan merged commit 1095224 into stable21 Jan 11, 2022
@CarlSchwan CarlSchwan deleted the fix/1867/fix-constant branch January 11, 2022 13:19
@TP75
Copy link
Contributor

TP75 commented Jan 11, 2022

However, I wonder why the apparent NC dev checks did not catch such a basic issue before going public.

#1215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solracsf solracsf solracsf approved these changes

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlSchwan @TP75 @solracsf