PoC: create and use Circles instead of Groups #1597
Conversation
|
The idea is to use SingleIds of the Circles App to add Group or Circle to the list of recipient. Right now, only work from the This is my list of available Circles: We will use:
Adding Circles to the groupfolder:
The singleId is stored in the database as it is, and used by the |
|
This is just a quick proof of concept, that will only be available in NC23. Will need last version of Circles from repository ( Also, lot of work to finalize this work:
|
skjnldsv
added
2. developing
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
enh/noid/poc-circle-folders
branch
from
5a9d365
to
316d1db
Compare
| @@ -46,7 +53,15 @@ export class Api { | |||
|
|
|||
| listGroups(): Thenable<Group[]> { | |||
| const version = parseInt(OC.config.version, 10); | |||
| if (version >= 14) { | |||
| if (version >= 22) { | |||
There was a problem hiding this comment.
Since this is likely never back ported below 22 we can drop the older code path.
|
|
||
| public function __construct(IDBConnection $connection, IUserMappingManager $userMappingManager) { | ||
| /** | ||
| * @var IEntityMappingManager |
There was a problem hiding this comment.
Could we find a better naming here instead of entity?
| $query->select('folder_id', 'mapping_type', 'mapping_id') | ||
| ->from('group_folders_manage', 'm'); | ||
|
|
||
| $queryHelper->addCircleDetails('m', 'mapping_id'); |
There was a problem hiding this comment.
Depending on if circles is then mandatory or if groups can still be used (which I'd vote for), we should have a possible or move anything circles related to a dedicated services to also allow the app to work if circles is disabled.
This is a quick and simple PoC that replace Groups with Circles.