Skip to content

🕵️ Add sharereview support - #3589

Merged
Chartman123 merged 1 commit into
mainfrom
feat/noid/sharereview
Aug 21, 2026
Merged

🕵️ Add sharereview support#3589
Chartman123 merged 1 commit into
mainfrom
feat/noid/sharereview

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Aug 19, 2026

Copy link
Copy Markdown
Member

expose form shares to share-review apps via OCP\Share\ShareReview

  • Implement IShareReviewSource listing all form shares with their capabilities mapped to ShareReviewPermission entries
  • gate deletions behind the ShareReviewAccessCheckEvent authorization check including revocation of linked uploaded-files shares
  • register the source via RegisterShareReviewSourceEvent.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@AndyScherzinger AndyScherzinger added enhancement New feature or request 3. to review Waiting for reviews labels Aug 19, 2026
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chartman123 Chartman123 added this to the 5.4 milestone Aug 19, 2026
Comment thread lib/ShareReview/ShareReviewSource.php Outdated
Comment thread lib/ShareReview/ShareReviewSource.php Outdated
…are\ShareReview

Implement IShareReviewSource listing all form shares with their
capabilities mapped to ShareReviewPermission entries, gate deletions
behind the ShareReviewAccessCheckEvent authorization check including
revocation of linked uploaded-files shares, and register the source
via RegisterShareReviewSourceEvent.

Assisted-by: Claude Code:claude-fable-5
Assisted-by: Claude Code:claude-opus-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

@Chartman123 Chartman123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@Chartman123
Chartman123 merged commit 55e02c9 into main Aug 21, 2026
53 checks passed
@Chartman123
Chartman123 deleted the feat/noid/sharereview branch August 21, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants