Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of ILogger #285

Merged
merged 1 commit into from
Sep 23, 2024
Merged

get rid of ILogger #285

merged 1 commit into from
Sep 23, 2024

Conversation

ArtificialOwl
Copy link
Member

No description provided.

@ArtificialOwl
get rid of ILogger
0c1f73e 
Signed-off-by: Maxence Lange <[email protected]>
come-nc
come-nc approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to see no tests update with all the constructor changes but it appears there are no tests?

@ArtificialOwl ArtificialOwl merged commit c1687f3 into master Sep 23, 2024
8 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/noid/get-rid-ilogger branch September 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtificialOwl @artonge @come-nc