Skip to content

fix(a11y): add dark-theme overrides for hardcoded light-theme colours #14839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skjnldsv wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −0
Open

fix(a11y): add dark-theme overrides for hardcoded light-theme colours #14839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions _shared_assets/static/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,31 @@ html[data-theme="dark"] .rst-content img {
box-shadow: 0 2px 8px rgba(255, 255, 255, 0.15);
}

/* Dark-theme overrides — sphinx-rtd-dark-mode sets data-theme="dark" on
<html>. The selectors below restore proper contrast for values that
were hardcoded for the light (white) background. */

/* Content links: #2474a4 gives only ~3.6:1 on the dark #141414 bg.
Defer to the plugin's own variable (= #249ee8, ~6:1 on dark bg). */
html[data-theme="dark"] .rst-content a,
html[data-theme="dark"] .rst-content a:visited {
color: var(--dark-link-color, #249ee8);
}

/* Inline code: #c0392b (dark red) gives ~2.4:1 on the #2d2d2d code bg,
and the !important above defeats the plugin's dark-mode rule entirely.
Use a lighter coral-red (~4.9:1 on #2d2d2d). */
html[data-theme="dark"] .rst-content code,
html[data-theme="dark"] .rst-content tt,
html[data-theme="dark"] code {
color: #ff7878 !important;
}

/* Search icon: #555 is near-invisible on the dark #0b152d sidebar bg. */
html[data-theme="dark"] .wy-form-search-icon {
color: #aaa;
}

/* ICONS LIST */
div#list-of-available-icons > blockquote {
margin: 0;
Expand Down
Loading