Skip to content

[stable32] Backport sphinx-lint CI (#14769) and enable all checks (#14771) to stable32#14817

Merged
skjnldsv merged 4 commits into
stable32from
copilot/backport-14769-and-14771-to-stable32
May 12, 2026
Merged

[stable32] Backport sphinx-lint CI (#14769) and enable all checks (#14771) to stable32#14817
skjnldsv merged 4 commits into
stable32from
copilot/backport-14769-and-14771-to-stable32

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 12, 2026

Backports two merged PRs from master to stable32:

PR #14769 — Add sphinx-lint CI for RST files

  • Adds .github/workflows/sphinx-lint.yml: lightweight CI job that runs sphinx-lint on admin_manual, developer_manual, and user_manual
  • Adds .github/problem-matchers/sphinx-lint.json for inline PR annotations
  • Adds sphinx-lint==1.0.2 to requirements.txt
  • Fixes pre-existing RST violations present in stable32 (missing final newlines, malformed hyperlinks, role markup errors)

PR #14771 — Enable trailing-whitespace and horizontal-tab checks

  • Removes --disable trailing-whitespace --disable horizontal-tab from the workflow
  • Fixes all trailing-whitespace, horizontal-tab, and missing-final-newline violations across 196 files in the three manuals
  • Fixes incorrect note directive continuation indentation in admin_manual/configuration_files/primary_storage.rst (line 175) that caused a docutils unindent warning
  • Re-applies tab-expansion and trailing-whitespace fixes to admin_manual/configuration_server/config_sample_php_parameters.rst after it was regenerated from config.sample.php in stable32
  • sphinx-lint now passes with no disabled rules

☑️ Resolves

🖼️ Screenshots

Copilot AI and others added 2 commits May 12, 2026 08:06
Backport of PR #14769 to stable32.

Adds sphinx-lint as a dedicated CI linting step for the three manuals,
and fixes all pre-existing violations so the check passes cleanly.

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Backport of PR #14771 to stable32.

Fixes all trailing-whitespace, horizontal-tab, and missing-final-newline
violations in admin_manual, developer_manual, and user_manual so the
full sphinx-lint check passes without any disabled rules.

Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Copilot AI requested a review from skjnldsv May 12, 2026 08:10
@skjnldsv skjnldsv requested a review from miaulalala May 12, 2026 08:11
@skjnldsv skjnldsv changed the title Backport sphinx-lint CI (#14769) and enable all checks (#14771) to stable32 [stable32] Backport sphinx-lint CI (#14769) and enable all checks (#14771) to stable32 May 12, 2026
@skjnldsv skjnldsv marked this pull request as ready for review May 12, 2026 08:12
Comment thread admin_manual/configuration_files/primary_storage.rst Outdated
Copilot AI requested a review from skjnldsv May 12, 2026 08:25
@skjnldsv
Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

…le32

Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 12, 2026

@copilot resolve the merge conflicts in this pull request

Resolved in caf2f88. The only conflict was in config_sample_php_parameters.rst — stable32 had regenerated it from config.sample.php (reintroducing tabs), while our branch had expanded those tabs. I took the new stable32 content and re-applied the expandtabs(4) + trailing-whitespace strip so sphinx-lint still passes cleanly.

@skjnldsv skjnldsv enabled auto-merge May 12, 2026 08:59
@skjnldsv skjnldsv merged commit 084195d into stable32 May 12, 2026
21 checks passed
@skjnldsv skjnldsv deleted the copilot/backport-14769-and-14771-to-stable32 branch May 12, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants