Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove php-exif #12234

Closed
wants to merge 2 commits into from
Closed

remove php-exif #12234

wants to merge 2 commits into from

Conversation

jameskimmel
Copy link

☑️ Resolves

  • not needed, since it is already enabled by default.

@tflidd
Copy link
Contributor

tflidd commented Sep 27, 2024

I don't see that it is required by the default setup of Nextcloud:
https://docs.nextcloud.com/server/latest/admin_manual/installation/php_configuration.html

@jameskimmel
Copy link
Author

jameskimmel commented Sep 27, 2024

It isn't. But also if you wanna make use of it, there is no need to install the module.
Another possibility would be to add (included with PHP) like we did for the fileinfo module in the same doc.

@kesselb
Copy link
Contributor

kesselb commented Sep 30, 2024

Thanks for your pull request 👍

How PHP is packaged depends on your operating system. It got better over the years and is now very similar for most distributions.

I usually check https://pkgs.org/download/php-exif for such questions. Ubuntu, Debian, Fedora and others bundle it with common. OpenSuse and Alpine have an extra package.

As there's no harm by listening php-exif here and an admin can always use php -m|grep exif to check if the module is there I would rather not merge it.

@jameskimmel
Copy link
Author

That makes total sense. Sorry that I wasn't aware of how this is handled.
Thank you for taking the time to look at it!

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants