Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): Revise opcache revalidation tuning section #11872

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 28, 2024

☑️ Resolves

  • Try to make PHP revalidation values, suggestions, and trade-offs more apparent (main focus of this PR)
  • Add big warnings about impact of lengthening frequency of revalidations and/or disabling outright
  • Try to make the opcache tuning section a bit more organized (move things around more logically, add sub-headings)

Also, related to pending enhancement: nextcloud/server#45498

Note: The main thing that is perhaps controversial here is the PHP default of 2 versus 60 (not so much because we ever formally recommended changing it to 60, but because 60 is already being used in both the AIO and micro-services/community Docker image). I'm of the camp that PHP's default of 2 should be emphasized. And any deviation from that is fine, but the operator making that change is on their own (and expected to restart/etc if needed). Fortunately with the Docker images (at least ours), at least for Server itself, it's less of an issue since the code upgrades only happen through a container restart (but still a factor for config.php + potentially for app updates).

Historical (most relevant):

🖼️ Screenshots

image

@joshtrichards
Copy link
Member Author

/backport to stable29

@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards
Copy link
Member Author

/backport to stable27

@joshtrichards joshtrichards requested a review from J0WI May 28, 2024 14:39
@kesselb
Copy link
Contributor

kesselb commented May 28, 2024

Thanks 👍

I thought about removing validate_timestamp because it appears that many people do not understand the implications.

This comment has been minimized.

@kesselb kesselb merged commit c04a2ea into master Jun 26, 2024
11 checks passed
@kesselb kesselb deleted the jtr/fix-enhance-opcache-revalidation-tuning branch June 26, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants