-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new OCS API documentation #10006
Conversation
f3d84b9
to
8f90bf0
Compare
39b76db
to
41ce5ab
Compare
41ce5ab
to
65896cb
Compare
65896cb
to
49989b5
Compare
49989b5
to
6f4bc91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a issue during build locally, but otherwise this looks really nice 🎉
Main blocker from my perspective:
https://github.com/nextcloud/documentation/pull/10006/files#r1205108612
aeffd0e
to
0d32040
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only checked the translation thing.
Maybe we can just keep the "old docs" in parallel until the transition of all the available information to the openapi spec was done?
c984438
to
db696c6
Compare
For me it does not load: Firefox
Chrome
|
How are you loading it? I think it's a problem with the web server. |
Also worked fine for me with |
@nickvergessen Is there something still missing? |
Signed-off-by: jld3103 <[email protected]>
2d72300
to
3435dac
Compare
I’m failing to build this:
|
That's the icons, they are broken since a long time. Unrelated to this change. You can comment the |
I tried instead of Web console shows:
|
See comments above. Try @juliushaertl's way to serve the documentation. |
I tried
|
While not a nice experience it is documented as
However the document sections Makefile doesn't cover the developer documentation pre-build steps which are in the main root makefile. Steps for testing manually:
I've pushed two commits to unblock this PR, but it would be nice to follow up with a cleaner solution so that either way of building involves the required build steps. |
I disabled the icons-docs in an earlier version of this PR, but @nickvergessen didn't want to have this. I agree with both sides, but prefer to not touch it in this PR. Better to have a separate PR that either fixes it in a correct way or disables/removes it. |
Good enough for me, at least I could test it and it works. Merge? |
I think @nickvergessen's concerns have been all addressed, but I don't really want to merge @juliushaertl commits in this PR. @juliushaertl could you make a separate PR? I'll happily approve that, but the commits really don't belong here. |
Removed the commits and pushed them to #10584 as they were based on this one. |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Thanks! ❤️ |
Meh, the problem @nickvergessen and @come-nc had with the illegal character thing also happen on the deployed version. Not sure what is going on there, I will investigate it (seems like some character set problem?) |
I wanted to link to the static file directly from the TOC, but it's not possible :/
Please don't merge yet, as the spec itself is not finalized.