Add PHP 8.3 support using workaround #2351
Open
+230
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As mentioned in #2202, the Nextcloud AIO repository recently introduced a temporary patch (=> nextcloud/all-in-one#5575) to address missing PHP 8.3 support for the Imagick library. This patch enables the image to be built with PHP 8.3.
Especially with PHP 8.4 support with Nextcloud 31 being on the horizon (see the upgrade guide), integrating this change would also presumably make the process of updating to PHP 8.4 down the line easier.
Changes
This PR backports the changes from AIO by integrating them into the existing templates.
Testing
30/apacheimage has been running without issues on my local server for several days.alpine/fpmimages were built but require additional testing by someone using this setup. Feedback on compatibility or functionality is appreciated.Compatibility
PHP 8.3 support was initially introduced in Nextcloud 28, which is the minimum supported version of this image. As a result, we can reasonably assume that all images are compatible with this change.
Any additional feedback or suggestions for improvement are of course greatly appreciated :-)