fix: Robustly parse file action responses and handle tooltip/URL children#9547
Open
fix: Robustly parse file action responses and handle tooltip/URL children#9547
Conversation
Signed-off-by: Rello <Rello@users.noreply.github.com>
fa25c7a to
bfa5972
Compare
Collaborator
Author
5 tasks
5 tasks
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
|
Artifact containing the AppImage: nextcloud-appimage-pr-9547.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Motivation
ocs.dataenvelope and usetooltipfor success messages.rootelement is absent or when child elements are incomplete.urlvalues against_accountUrland improve logging for unsupported response elements.Description
#include <optional>and updatedFileActionsModel::processRequestto extractocs.dataand thetooltipstring from the JSON response.ocs.data.rootwhen top-levelrootis empty and prefertooltipover the generic success message when present.setGenericResponseandparseChildResponselambdas;parseChildResponsereturns astd::optional<Response>and validateselement,text, andurlfields and resolves relative URLs against_accountUrl.Testing
cmakeand the changes compiled without errors.ctest, and all tests completed successfully.Codex Task