Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(l10n): Remove leading spaces #7296

Closed
wants to merge 1 commit into from
Closed

Conversation

rakekniven
Copy link
Member

Reported at Transifex

Reported at Transifex

Signed-off-by: rakekniven <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7296-02bf42d1f8b0151da632ad78faed44eb97654071-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
28 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the strings in the UI as we are appending the reason string to the initial string containing what the error is

I think an even. better solution would be to define the reason string separately and then afterwards create the item->_errorString with the reason added as a QString arg

@rakekniven
Copy link
Member Author

Hello Claudio,

as I am not a developer this sounds good ;-)

What I can say from a translator perspective is: Never use a leading or trailing space for a string.
Just checked existing translations and some are missing the leading space already. One used a nbsp for it.

Would you mind adapting this PR or creating the solution in another PR?

@claucambra
Copy link
Collaborator

@rakekniven I have opened #7316 to fix the root issue, feel free to review :)

@rakekniven rakekniven closed this Oct 14, 2024
@rakekniven rakekniven deleted the rakekniven-patch-1 branch October 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants