Clear error list after displaying it once.

src/gui/accountstate.cpp

@@ -1,4 +1,4 @@
 /*
  * Copyright (C) by Daniel Molkentin <[email protected]>
  *
  * This program is free software; you can redistribute it and/or modify
@@ -130,8 +130,9 @@
             emit isConnectedChanged();
         }
         if (_state == Connected) {
+            _connectionErrors.clear();
             resetRetryCount();
-        }
+        } 
     }
 
     // might not have changed but the underlying _connectionErrors might have
@@ -487,6 +488,7 @@
         // connection validation, even if it's currently running.
         _connectionValidator->deleteLater();
         _connectionValidator = nullptr;
+        _connectionErrors.clear();
     }
 
     checkConnectivity();

src/gui/connectionvalidator.cpp

@@ -1,4 +1,4 @@
 /*
  * Copyright (C) by Klaas Freitag <[email protected]>
  *
  * This program is free software; you can redistribute it and/or modify
@@ -12,7 +12,7 @@
  * for more details.
  */
 
 #include <QJsonDocument>
 #include <QJsonObject>
 #include <QJsonArray>
 #include <QLoggingCategory>
@@ -48,6 +48,7 @@
 void ConnectionValidator::checkServerAndAuth()
 {
     if (!_account) {
+        _statusErrorMap.insert(NotConfigured, tr("No Nextcloud account configured"));
         _errors << tr("No Nextcloud account configured");
         reportResult(NotConfigured);
         return;
@@ -165,9 +166,10 @@
 
     if (!_account->credentials()->stillValid(reply)) {
         // Note: Why would this happen on a status.php request?
+        _statusErrorMap.insert(StatusNotFound, tr("Authentication error: Either username or password are wrong."));
         _errors.append(tr("Authentication error: Either username or password are wrong."));
     } else {
-        //_errors.append(tr("Unable to connect to %1").arg(_account->url().toString()));
+        _statusErrorMap.insert(StatusNotFound, job->errorString());
         _errors.append(job->errorString());
     }
     reportResult(StatusNotFound);
@@ -176,7 +178,7 @@
 void ConnectionValidator::slotJobTimeout(const QUrl &url)
 {
     Q_UNUSED(url);
-    //_errors.append(tr("Unable to connect to %1").arg(url.toString()));
+    _statusErrorMap.insert(Timeout, tr("Timeout"));
     _errors.append(tr("Timeout"));
     reportResult(Timeout);
 }
@@ -208,16 +210,19 @@
     Status stat = Timeout;
 
     if (reply->error() == QNetworkReply::SslHandshakeFailedError) {
+        _statusErrorMap.insert(SslError, job->errorStringParsingBody());
         _errors << job->errorStringParsingBody();
         stat = SslError;
 
     } else if (reply->error() == QNetworkReply::AuthenticationRequiredError
         || !_account->credentials()->stillValid(reply)) {
         qCWarning(lcConnectionValidator) << "******** Password is wrong!" << reply->error() << job->errorString();
+        _statusErrorMap.insert(CredentialsWrong, tr("The provided credentials are not correct"));
         _errors << tr("The provided credentials are not correct");
         stat = CredentialsWrong;
 
     } else if (reply->error() != QNetworkReply::NoError) {
+        _statusErrorMap.insert(Undefined, job->errorStringParsingBody());
         _errors << job->errorStringParsingBody();
 
         const int httpStatus =
@@ -285,6 +290,7 @@
     // We cannot deal with servers < 7.0.0
     if (_account->serverVersionInt()
         && _account->serverVersionInt() < Account::makeServerVersion(7, 0, 0)) {
+        _statusErrorMap.insert(ServerVersionMismatch, tr("The configured server for this client is too old. Please update to the latest server and restart the client."));
         _errors.append(tr("The configured server for this client is too old"));
         _errors.append(tr("Please update to the latest server and restart the client."));
         reportResult(ServerVersionMismatch);
@@ -331,18 +337,39 @@
 {
     emit connectionResult(status, _errors);
 
-    // notify user of errors
     if (!_errors.isEmpty() && _previousErrors != _errors) {
-       showSystrayErrorMessage();
+        showSystrayErrorMessage(status);
     }
 
     deleteLater();
 }
 
-void ConnectionValidator::showSystrayErrorMessage()
+void ConnectionValidator::showSystrayErrorMessage(Status status)
 {
-    Systray::instance()->showMessage(tr("Connection issue"),
-                                     _errors.join("<br>"),
+    // not all Status are considered errors
+    constexpr auto statusString = [&](Status currentStatus) {
+        switch (currentStatus) {
+        case Status::Undefined:
+            return tr("Undefined issue");
+        case Status::NotConfigured:
+            return tr("Account not configured");
+        case Status::ServerVersionMismatch:
+            return tr("Server version mismatch");
+        case Status::CredentialsWrong:
+            return tr("Credentials issue");
+        case Status::StatusNotFound:
+        case Status::Timeout:
+            return tr("Connection issue");
+        case Status::ServiceUnavailable:
+            return tr("Service unavailable");
+        case Status::MaintenanceMode:
+            return tr("Mantainance mode");
+        default:
+            return QString();
+        }
+    };
+    Systray::instance()->showMessage(statusString(status),
+                                     _statusErrorMap.value(status),
                                      QSystemTrayIcon::Warning);
 }
 

src/gui/connectionvalidator.h

@@ -15,7 +15,7 @@
 #ifndef CONNECTIONVALIDATOR_H
 #define CONNECTIONVALIDATOR_H
 
 #include "owncloudlib.h"
 #include <QObject>
 #include <QStringList>
 #include <QVariantMap>
@@ -146,11 +146,12 @@
 
     const QStringList _previousErrors;
     QStringList _errors;
+    QMap<Status, QString> _statusErrorMap;
     AccountStatePtr _accountState;
     AccountPtr _account;
     bool _isCheckingServerAndAuth = false;
 
-    void showSystrayErrorMessage();
+    void showSystrayErrorMessage(Status status);
 };
 }