Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/6498/stable 3.12 #6534

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Conversation

camilasan
Copy link
Member

No description provided.

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6534-cd64e71d8e630ae8910ff708bcbb28931d029f79-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

#include <QString>
#include <QUrl>

#import <Cocoa/Cocoa.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
Cocoa/Cocoa.h file not found


#include <QWindow>

#import <Cocoa/Cocoa.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
Cocoa/Cocoa.h file not found

Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tobiasKaminsky tobiasKaminsky merged commit 7ac853c into stable-3.12 Mar 12, 2024
10 of 13 checks passed
@tobiasKaminsky tobiasKaminsky deleted the backport/6498/stable-3.12 branch March 12, 2024 06:40
@core-code
Copy link

so, does 3.12.2 still require macOS 12? no changes were mentioned in github or the homepage

@mgallien mgallien added this to the 3.12.4 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants