Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2EE with VFS. Disallow MOVE as it is not supported. Prevent data loss. #6528

Merged
merged 1 commit into from
Mar 20, 2024
Merged

E2EE with VFS. Disallow MOVE as it is not supported. Prevent data loss. #6528

merged 1 commit into from
Mar 20, 2024

Conversation

allexzander
Copy link
Contributor

It's not a regression. This never worked and I am not surprised as this is not possible with the current server limitation for E2EE files MOVE not supported and performed via DELETE + PUT.

@allexzander allexzander force-pushed the bugfix/e2ee-vfs-disallow-move branch 3 times, most recently from e053b6d to abedb28 Compare March 10, 2024 12:08
@allexzander
Copy link
Contributor Author

/backport to stable-3.12

mgallien
mgallien requested changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an automated test

src/libsync/discovery.cpp Outdated Show resolved Hide resolved
src/libsync/discovery.cpp Outdated Show resolved Hide resolved
@allexzander allexzander force-pushed the bugfix/e2ee-vfs-disallow-move branch from 1dd8f16 to 5642960 Compare March 12, 2024 20:43
@allexzander
Copy link
Contributor Author

please add an automated test

I tend to disagree. The e2e-to-end encryption interaction between client and server is way too complicated to implement unit tests for it. This requires writing most of the endpoints the server is using for E2EE, not just simple PROPFIND.
This type of tests require different testing approach, called end-to-end testing (or QA automation), for which, we do not have capacity.

@allexzander allexzander force-pushed the bugfix/e2ee-vfs-disallow-move branch from 5642960 to 70d1873 Compare March 17, 2024 18:45
@allexzander allexzander force-pushed the bugfix/e2ee-vfs-disallow-move branch from 70d1873 to b749cf9 Compare March 20, 2024 00:08
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6528-b749cf9748c40b41db6d7396b8aa39b82c37a2fe-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 53eef98 into master Mar 20, 2024
10 of 12 checks passed
@allexzander allexzander deleted the bugfix/e2ee-vfs-disallow-move branch March 20, 2024 00:32
@backportbot backportbot bot mentioned this pull request Mar 20, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@allexzander @nextcloud-desktop-bot @mgallien