Simplify window positioning compute, more flexibly handle different available geometries #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
approved these changes
Jan 29, 2024
Signed-off-by: Claudio Cambra <[email protected]>
…measurement unit to define non-taskbar invading window positions, removing need for calculating taskbar geometry Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
mgallien
force-pushed
the
bugfix/window-pos-compute
branch
from
3296d98
to
b1a50f4
Compare
|
AppImage file: nextcloud-PR-6353-b1a50f42bed99685fd0ef3a5281151306c30aa39-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the calculation of safe spaces for the tray window to be positioned in by using Qt's inbuilt available screen geometries, rather than us trying to manually calculate the taskbar geometry
Requires testing on Linux and Windows