-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite communication between client and File Provider extensions using XPC #6324
Commits on Feb 19, 2024
-
Add starter client communication service
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 22c176a - Browse repository at this point
Copy the full SHA 22c176aView commit details -
Keep pointer to FileProviderExtension around in ClientCommunicationSe…
…rvice Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a2d69fc - Browse repository at this point
Copy the full SHA a2d69fcView commit details -
Add ClientCommunicationProtocol
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e763a9d - Browse repository at this point
Copy the full SHA e763a9dView commit details -
Implement ClientCommunicationProtocol in ClientCommunicationService
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd39991 - Browse repository at this point
Copy the full SHA dd39991View commit details -
Reimplement ClientCommunicationService in Swift
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 026f082 - Browse repository at this point
Copy the full SHA 026f082View commit details -
Properly implement listener should accept connection in ClientCommuni…
…cationService Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ac43369 - Browse repository at this point
Copy the full SHA ac43369View commit details -
Add starter FileProviderXPC class on client side
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5cc8b6e - Browse repository at this point
Copy the full SHA 5cc8b6eView commit details -
Add relative symlink to ClientCommunicationProtocol in srd/gui/macOS
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e8c1bbb - Browse repository at this point
Copy the full SHA e8c1bbbView commit details -
Fix logging for fileproviderdomainmanager
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9dddaf4 - Browse repository at this point
Copy the full SHA 9dddaf4View commit details -
Implement connection begin in XPC
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2520111 - Browse repository at this point
Copy the full SHA 2520111View commit details -
Flatten FileProviderXPC::start()
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0b505a9 - Browse repository at this point
Copy the full SHA 0b505a9View commit details -
Fix retain issues with domains in FileProviderXPC
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d4d0cf5 - Browse repository at this point
Copy the full SHA d4d0cf5View commit details -
Ensure FileProvider components instantiated after account setup
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a6e3f18 - Browse repository at this point
Copy the full SHA a6e3f18View commit details -
Add extensionAccountId property to ClientCommunicationProtocol
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5f6f7f3 - Browse repository at this point
Copy the full SHA 5f6f7f3View commit details -
Cache NSXPCConnections when starting FileProviderXPC
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ee82968 - Browse repository at this point
Copy the full SHA ee82968View commit details -
Ensure the listener is resumed once the endpoint is created in the ex…
…tension Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2d1e5ba - Browse repository at this point
Copy the full SHA 2d1e5baView commit details -
Check for protocol type in fileproviderxpc start
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb774ad - Browse repository at this point
Copy the full SHA eb774adView commit details -
Log extension id sent over XPC publicly
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6cb7169 - Browse repository at this point
Copy the full SHA 6cb7169View commit details -
Retrieve extension account ids over XPC, store client comm service pe…
…r account Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7716860 - Browse repository at this point
Copy the full SHA 7716860View commit details -
Upon acquisition of client communication services, send account confi…
…guration Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 59b8b8e - Browse repository at this point
Copy the full SHA 59b8b8eView commit details -
Move domain manager acquisition into separate function
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8eaf4e6 - Browse repository at this point
Copy the full SHA 8eaf4e6View commit details -
Move domain url acquisition to separate function
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4a8d501 - Browse repository at this point
Copy the full SHA 4a8d501View commit details -
Move acquisition of file provider services to different function
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a0376a2 - Browse repository at this point
Copy the full SHA a0376a2View commit details -
Moved XPC Utils into separate file
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5ee2cfa - Browse repository at this point
Copy the full SHA 5ee2cfaView commit details -
Clean up FileProviderXPC code, separate everything into single-respon…
…sibility methods Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 95bebc5 - Browse repository at this point
Copy the full SHA 95bebc5View commit details -
Fix clientcommservices datatype
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6f5b07c - Browse repository at this point
Copy the full SHA 6f5b07cView commit details -
Implement NSFileProviderServicing in FileProviderExtension
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5ed456f - Browse repository at this point
Copy the full SHA 5ed456fView commit details -
Extract file provider connection configuration into separate util fun…
…ction Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 595c23c - Browse repository at this point
Copy the full SHA 595c23cView commit details -
Extract remote service object acquisistion from connection into separ…
…ate function Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9997ce - Browse repository at this point
Copy the full SHA c9997ceView commit details -
Remove redundant static in anonymous fileproviderxpc utils namespace
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8a8d3b3 - Browse repository at this point
Copy the full SHA 8a8d3b3View commit details -
Extract account id acquisition from clientCommService into separate f…
…unction Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 23a3a3e - Browse repository at this point
Copy the full SHA 23a3a3eView commit details -
Cast clientCommServices to NSObject with correct protocol
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 502d738 - Browse repository at this point
Copy the full SHA 502d738View commit details -
Add method to unauthenticate file provider extension in FileProviderXPC
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f728ec1 - Browse repository at this point
Copy the full SHA f728ec1View commit details -
Define NSDictionary types in _clientCommServices
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 94bfa03 - Browse repository at this point
Copy the full SHA 94bfa03View commit details -
Move extension authentication into separate method
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c1fa662 - Browse repository at this point
Copy the full SHA c1fa662View commit details -
Implement recognition of account state changing in FileProviderXPC
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0856138 - Browse repository at this point
Copy the full SHA 0856138View commit details -
Fix clang-tidy namespace concatenation warning
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fca6b37 - Browse repository at this point
Copy the full SHA fca6b37View commit details -
Remove all obj-c classes from fileproviderxpc.h
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 784cd12 - Browse repository at this point
Copy the full SHA 784cd12View commit details -
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for be3bd7b - Browse repository at this point
Copy the full SHA be3bd7bView commit details -
Remove unused extension ID NSString
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6d4e785 - Browse repository at this point
Copy the full SHA 6d4e785View commit details -
Use accountStateFromFileProviderDomainIdentifier method in authentica…
…teExtension Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 43b7ae5 - Browse repository at this point
Copy the full SHA 43b7ae5View commit details -
Improve domain discovery logging
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 798f77f - Browse repository at this point
Copy the full SHA 798f77fView commit details -
Get services using better non-url based method if available (macOS 13…
….0+) Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 58dc42a - Browse repository at this point
Copy the full SHA 58dc42aView commit details -
Separate starting of domain manager tasks from constructor
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4238912 - Browse repository at this point
Copy the full SHA 4238912View commit details -
Separate XPC init from file provider constructor
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 45b1231 - Browse repository at this point
Copy the full SHA 45b1231View commit details -
Only start XPC after file provider domains have been configured
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a01e552 - Browse repository at this point
Copy the full SHA a01e552View commit details -
Simplify and clarify utility of socket system for file provider
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a44454d - Browse repository at this point
Copy the full SHA a44454dView commit details -
Clarify utility of xpc system for file provider
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 41133e4 - Browse repository at this point
Copy the full SHA 41133e4View commit details -
Add explainer to client interface
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b22f463 - Browse repository at this point
Copy the full SHA b22f463View commit details -
Simplify xpc service acquisition completion handler
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9611e47 - Browse repository at this point
Copy the full SHA 9611e47View commit details -
Improve socket controller logging
Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 71119fe - Browse repository at this point
Copy the full SHA 71119feView commit details -
Do not reconfigure file provider extension account if we are receivin…
…g the same details again Signed-off-by: Claudio Cambra <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3334b4e - Browse repository at this point
Copy the full SHA 3334b4eView commit details