Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Allow resharing" option to share dialog #5965

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

claucambra
Copy link
Collaborator

Screenshot 2023-08-10 at 16 15 23

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #5965 (d428915) into master (aec5f09) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5965   +/-   ##
=======================================
  Coverage   60.11%   60.11%           
=======================================
  Files         145      145           
  Lines       18801    18801           
=======================================
  Hits        11303    11303           
  Misses       7498     7498           

see 2 files with indirect coverage changes

Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra one change please, and one question from me

src/gui/filedetails/sharemodel.cpp Outdated Show resolved Hide resolved
src/gui/sharepermissions.h Show resolved Hide resolved
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra
Kindly squash commit history

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5965-d428915d35aedcf8d11610519af74f6df127edfa-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit c805e20 into master Aug 11, 2023
11 of 12 checks passed
@claucambra claucambra deleted the feature/allow-resharing-share branch August 11, 2023 16:26
@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants