oc desktop client login migration to nc desktop client login #5959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5959 +/- ##
==========================================
- Coverage 60.29% 60.08% -0.21%
==========================================
Files 145 145
Lines 18838 18838
==========================================
- Hits 11358 11319 -39
- Misses 7480 7519 +39
|
camilasan
force-pushed
the
bugfix/oc-account-login
branch
3 times, most recently
from
f6cc299
to
7daeec9
Compare
camilasan
changed the title
camilasan
force-pushed
the
bugfix/oc-account-login
branch
from
7daeec9
to
7c7ac9c
Compare
claucambra
reviewed
Aug 25, 2023
camilasan
force-pushed
the
bugfix/oc-account-login
branch
3 times, most recently
from
88cc6de
to
426a61b
Compare
camilasan
force-pushed
the
bugfix/oc-account-login
branch
2 times, most recently
from
8f85884
to
54b5635
Compare
camilasan
force-pushed
the
bugfix/oc-account-login
branch
2 times, most recently
from
77f5e8c
to
300e850
Compare
claucambra
requested changes
Sep 1, 2023
camilasan
force-pushed
the
bugfix/oc-account-login
branch
2 times, most recently
from
b204303
to
2c6efe7
Compare
allexzander
reviewed
Sep 1, 2023
allexzander
reviewed
Sep 1, 2023
camilasan
force-pushed
the
bugfix/oc-account-login
branch
from
2c6efe7
to
9a5ed82
Compare
allexzander
approved these changes
Sep 1, 2023
camilasan
force-pushed
the
bugfix/oc-account-login
branch
from
9a5ed82
to
136585e
Compare
added 5 commits
September 1, 2023 15:09
- Add {} for single line condition, const auto and fix comments.
- Save the legacy account data first in _settingsMap, so the legacy config file
does not get changed in the migration process.
- Legacy dav_user should stay only as dav_user in the new config.
- Compare davUser and prettyName only when new user id needs to be retrieved.
Signed-off-by: Camila <[email protected]>
- Migrate only the current config in use by the legacy application. Signed-off-by: Camila <[email protected]>
- Refactor migration of blacklisted folders. - Only change selective sync list if needed. Signed-off-by: Camila <[email protected]>
- Refactor ConfigFile::setupDefaultExcludeFilePaths. - Refactor ConfigFile::excludeFile. - Fix code style. Signed-off-by: Camila <[email protected]>
- Always used a sqlite compiled version or a version from KDE Craft - When building the AppImage copy the sqlite files to the /usr/lib/ folder in it. Signed-off-by: Camila <[email protected]>
camilasan
force-pushed
the
bugfix/oc-account-login
branch
from
136585e
to
0936201
Compare
|
AppImage file: nextcloud-PR-5959-0936201d804b2abb57d240a22e0e0c55cf1d1af3-x86_64.AppImage |
|
SonarCloud Quality Gate failed.
|
claucambra
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.