Convert VFS file to placeholder again if needed #5889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m7913d
force-pushed
the
fixNonExistingPlaceholder
branch
from
3c20da6
to
5856376
Compare
mgallien
requested changes
Jul 20, 2023
|
/backport to stable-3.9 |
m7913d
force-pushed
the
fixNonExistingPlaceholder
branch
2 times, most recently
from
2e08f38
to
e5e526f
Compare
This was referenced Jul 24, 2023
mgallien
force-pushed
the
fixNonExistingPlaceholder
branch
from
e5e526f
to
52906d8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5889 +/- ##
==========================================
- Coverage 60.08% 60.03% -0.06%
==========================================
Files 145 145
Lines 18762 18771 +9
==========================================
- Hits 11273 11269 -4
- Misses 7489 7502 +13
|
allexzander
reviewed
Jul 24, 2023
mgallien
approved these changes
Jul 26, 2023
Note that Windows may convert a placeholder file to a regular file when it is replaced by another file, even if the old and new file (inode, modified time, file size) are identical. WIN32_FIND_DATA::dwReserved0 is only initialised in case of FILE_ATTRIBUTE_REPARSE_POINT is set. This field is not a bit set. Check corrected to only include all cloud reparse points and not other special reparse points. Signed-off-by: Dries Mys <[email protected]>
Signed-off-by: Dries Mys <[email protected]>
Signed-off-by: Dries Mys <[email protected]>
mgallien
force-pushed
the
fixNonExistingPlaceholder
branch
from
07f0cd3
to
243fcfe
Compare
|
AppImage file: nextcloud-PR-5889-243fcfedb92b56b69d8272108cb7366fca18a1be-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that Windows may convert a placeholder file to a regular file when it is replaced by another file, even if the old and new file (inode, modified time, file size) are identical.
Steps to reproduce the the issue: