Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly fetch shares for files with spaces/other special characters in filenames #5884

Closed
wants to merge 4 commits into from
Closed

Properly fetch shares for files with spaces/other special characters in filenames #5884

wants to merge 4 commits into from

Commits on Jul 12, 2023

  1. Modernise ShareManager::slotSharesFetched 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f2d5988 View commit details
    Browse the repository at this point in the history

  2. Make an early return when canShare() is false in ShareModel::initShar… 

    …eManager

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    cc95a1e View commit details
    Browse the repository at this point in the history

  3. Ensure _sharePath is properly percent encoded by using QUrl::toPercen… 

    …tEncoding

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    48f1dfa View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Move share path setting in sharemodel into separate private method 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    7f1216e View commit details
    Browse the repository at this point in the history