Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not modify discovered files on disk if not necessary #5872

Merged
merged 8 commits into from
Aug 7, 2023
Merged

Do not modify discovered files on disk if not necessary #5872

merged 8 commits into from
Aug 7, 2023

Commits on Aug 7, 2023

  1. Unify else and if in SyncEngine::slotItemDiscovered for filesystem se… 

    …tmodtime check

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3214534 View commit details
    Browse the repository at this point in the history

  2. Return bool from FileSystem::setFileReadOnlyWeak depending on whether… 

    … permission change was actually made or not

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    9811d35 View commit details
    Browse the repository at this point in the history

  3. Only change modification time if any modifications were actually made… 

    … on downsynced file

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    fe829e2 View commit details
    Browse the repository at this point in the history

  4. Only attempt conversion to placeholder on new file if VFS enabled in … 

    …SyncEngine::slotItemDiscovered

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    961033e View commit details
    Browse the repository at this point in the history

  5. Ensure file modification time is set if item modtime differs from jou… 

    …rnal modtime

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4681d27 View commit details
    Browse the repository at this point in the history

  6. Add find method to DiskFileModifier class in SyncEngineTestUtils 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    67e6546 View commit details
    Browse the repository at this point in the history

  7. Add test for unmodified local files not getting mtimes changed upon u… 

    …pload to server

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1cd537f View commit details
    Browse the repository at this point in the history

  8. Set modificationHappened to also depend on file size change 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    812e696 View commit details
    Browse the repository at this point in the history