Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new state and new job to check if /index.php/204 is being redirected #5848

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Added new state and new job to check if /index.php/204 is being redirected #5848

merged 1 commit into from
Jul 17, 2023

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Jun 29, 2023 •
edited
Loading

No description provided.

@allexzander allexzander changed the title Added new state and new job to check if /index.php/204 is being redir… Added new state and new job to check if /index.php/204 is being redirected Jun 29, 2023
@allexzander allexzander linked an issue Jun 29, 2023 that may be closed by this pull request
captive portals should be detected and handled #81
Closed
@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #5848 (ed3c952) into master (6c12a22) will decrease coverage by 0.06%.
The diff coverage is 53.57%.

❗ Current head ed3c952 differs from pull request most recent head 71f1d1a. Consider uploading reports for the commit 71f1d1a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5848      +/-   ##
==========================================
- Coverage   60.15%   60.09%   -0.06%     
==========================================
  Files         145      145              
  Lines       18718    18746      +28     
==========================================
+ Hits        11259    11265       +6     
- Misses       7459     7481      +22
Impacted Files Coverage Δ
src/libsync/abstractnetworkjob.cpp 72.24% <ø> (+1.14%) ⬆️
src/libsync/abstractnetworkjob.h 53.84% <ø> (ø)
src/libsync/networkjobs.h 12.50% <0.00%> (-0.55%) ⬇️
src/libsync/networkjobs.cpp 60.07% <55.55%> (-0.17%) ⬇️

... and 3 files with indirect coverage changes

@allexzander allexzander force-pushed the feature/detect-captive-portal branch from 60e8456 to cfcb57f Compare July 6, 2023 09:06
mgallien
mgallien requested changes Jul 7, 2023
View reviewed changes
src/libsync/networkjobs.h Outdated Show resolved Hide resolved
src/libsync/networkjobs.cpp Outdated Show resolved Hide resolved
src/libsync/networkjobs.cpp Outdated Show resolved Hide resolved
@allexzander allexzander requested a review from mgallien July 7, 2023 13:52
mgallien
mgallien requested changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small new comments

src/libsync/networkjobs.cpp Outdated Show resolved Hide resolved
src/libsync/networkjobs.cpp Outdated Show resolved Hide resolved
mgallien
mgallien reviewed Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allexzander can you clean commits history ?

@allexzander allexzander force-pushed the feature/detect-captive-portal branch from ed3c952 to 71f1d1a Compare July 17, 2023 09:31
@mgallien mgallien enabled auto-merge July 17, 2023 09:37
@allexzander
Copy link
Contributor Author

/backport to stable-3.9

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5848-71f1d1aad46cb00ab7bf70709c273623bd255511-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

1.9% 1.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mgallien mgallien merged commit 5ab5483 into master Jul 17, 2023
10 of 12 checks passed
@mgallien mgallien deleted the feature/detect-captive-portal branch July 17, 2023 10:21
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 17, 2023
Merged
@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

captive portals should be detected and handled
3 participants
@allexzander @nextcloud-desktop-bot @mgallien