Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure errors are displayed as first entries in tray window activity list, add testing for SortedActivityListModel #5408

Merged
merged 22 commits into from
Jul 25, 2023
Merged

Ensure errors are displayed as first entries in tray window activity list, add testing for SortedActivityListModel #5408

merged 22 commits into from
Jul 25, 2023

Commits on Jul 25, 2023

  1. Move activity list syncfileitemstatus errors to the top of the list 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a5e2de7 View commit details
    Browse the repository at this point in the history

  2. Move activity list SyncResult errors to the top of the list 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    68d92e1 View commit details
    Browse the repository at this point in the history

  3. Place all sorts of sync file item status errors near the top 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    55fc6a1 View commit details
    Browse the repository at this point in the history

  4. Move FakeRemoteActivityStorate to new activitylistmodeltestutils 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    00ac5a4 View commit details
    Browse the repository at this point in the history

  5. Move TestingALM to activitylistmodeltestutils 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1c16728 View commit details
    Browse the repository at this point in the history

  6. Replace unnecessary folder include in ActivityData with SyncResult 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6364c62 View commit details
    Browse the repository at this point in the history

  7. Move activitylistmodel testing QNAM override to dedicated convenience… 

    … method in ActivityTestUtils

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e42f5cf View commit details
    Browse the repository at this point in the history

  8. Move creation of example activities from testactivitylistmodel to act… 

    …ivitylistmodeltestutils

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    06a4290 View commit details
    Browse the repository at this point in the history

  9. Add SortedActivityListModel test 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    8003fcd View commit details
    Browse the repository at this point in the history

  10. Verify sorted model is showing the rows in source activity model 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    bbb0cdd View commit details
    Browse the repository at this point in the history

  11. Add test to check that the sortedactivitylistmodel correctly gets upd… 

    …ated when the sourcemodel does

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a111193 View commit details
    Browse the repository at this point in the history

  12. Make TestingALM a friend class of ActivityListModel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    cd56841 View commit details
    Browse the repository at this point in the history

  13. Expose insert dummy activity method in TestingALM 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1585c2e View commit details
    Browse the repository at this point in the history

  14. Fix fetch handling in TestingALM 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    aa00b47 View commit details
    Browse the repository at this point in the history

  15. Clean up declarations in activitylistmodel header, remove unused methods 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b7283fa View commit details
    Browse the repository at this point in the history

  16. Add convenience method in TestingALM to fetch more than maximum activ… 

    …ities to be displayed in activitylistmodel

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2677717 View commit details
    Browse the repository at this point in the history

  17. Expose max activities in TestingALM 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b3f209e View commit details
    Browse the repository at this point in the history

  18. Expose max activity data from activity list model in TestingALM 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6d3bbe8 View commit details
    Browse the repository at this point in the history

  19. Test sorted activity list model sort order 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    af3146d View commit details
    Browse the repository at this point in the history

  20. Fix setting of sourcemodel in sorted activity list test 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    68d8921 View commit details
    Browse the repository at this point in the history

  21. Fix testing of sync result error activities in sorted activity list test 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    de4ae7c View commit details
    Browse the repository at this point in the history

  22. Use nodiscard in TestingALM 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    74bdbb4 View commit details
    Browse the repository at this point in the history