Use macOS-specific application icon

[claucambra]

Signed-off-by: Claudio Cambra [email protected]

[elsiehupp]

Is this for the purpose of facilitating #4367? (As I read it this pull request is basically just clarifying that the particular SVG in question is only used for the Finder sidebar and not, say, the Nautilus sidebar, which wasn't terribly clear from the previous nomenclature.)

[claucambra]

Is this for the purpose of facilitating #4367? (As I read it this pull request is basically just clarifying that the particular SVG in question is only used for the Finder sidebar and not, say, the Nautilus sidebar, which wasn't terribly clear from the previous nomenclature.)

No, this is to set the application's icon to your Big Sur-style icon in #4631

[elsiehupp]

On some level I think it would be useful to clarify in the filename that the sidebar icon is specifically used by the Finder, but it could also make sense make the nomenclature more generic, like Nextcloud-{platform}-shell-sidebar, if you wanted to facilitate slight variations for, e.g., Windows Explorer, Nautilus, Dolphin, elementary Files, etc. (How the distinction for different Linux shells would be implemented would probably be a bit more complicated than, say, the distinction between Windows and macOS.)

[elsiehupp]

For instance, #2903 touches on the Windows Explorer sidebar icon, and apparently I opened #2950 to address Linux-shell sidebar icons, as well.

[elsiehupp]

In the case of Linux shells that use the XDG Icon Theme Specification, it could work to assign the Nextcloud folder a filesystem attribute with the icon name and then provide the Nextcloud (or vendor) logo as icon, though I'm not 100% sure how that would work with sandboxed versions of Nextcloud Desktop such as Flatpak.

This is a bit of a digression, but again my main point here is that Nextcloud-{platform}-shell-sidebar could potentially facilitate better shell-sidebar icon support on platforms other than macOS.

[elsiehupp]

Is this for the purpose of facilitating #4367? (As I read it this pull request is basically just clarifying that the particular SVG in question is only used for the Finder sidebar and not, say, the Nautilus sidebar, which wasn't terribly clear from the previous nomenclature.)

No, this is to set the application's icon to your Big Sur-style icon in #4631

Ah, okay!

[claucambra]

In the case of Linux shells that use the XDG Icon Theme Specification, it could work to assign the Nextcloud folder a filesystem attribute with the icon name and then provide the Nextcloud (or vendor) logo as icon, though I'm not 100% sure how that would work with sandboxed versions of Nextcloud Desktop such as Flatpak.

This is a bit of a digression, but again my main point here is that Nextcloud-{platform}-shell-sidebar could potentially facilitate better shell-sidebar icon support on platforms other than macOS.

I think this naming structure would make things clearer, but it would also require changes to our branding infra (which I am not super familiar with). Worth discussing though :)

[codecov]

Codecov Report

Merging #4707 (e8cc369) into master (bc01db7) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4707      +/-   ##
==========================================
+ Coverage   56.41%   56.57%   +0.15%     
==========================================
  Files         138      138              
  Lines       17068    17068              
==========================================
+ Hits         9629     9656      +27     
+ Misses       7439     7412      -27     

Impacted Files	Coverage Δ
src/libsync/discovery.cpp	84.86% <0.00%> (+0.29%)	⬆️
src/libsync/syncengine.cpp	85.74% <0.00%> (+0.54%)	⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp	77.34% <0.00%> (+1.92%)	⬆️
src/libsync/vfs/cfapi/vfs_cfapi.cpp	86.46% <0.00%> (+2.62%)	⬆️
src/libsync/vfs/cfapi/hydrationjob.cpp	56.45% <0.00%> (+3.76%)	⬆️

[camilasan]

/backport to stable-3.5

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4707-e8cc3690ce6e9793e6da1d4252a72992e6f2b6d5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[backportbot-nextcloud]

The backport to stable-3.5 failed. Please do this backport manually.