Simplify xpc service acquisition completion handler

nextcloud · Jan 23, 2024 · 2ae4692 · 2ae4692
1 parent 326cdb0
commit 2ae4692
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/gui/macOS/fileproviderxpc_mac_utils.mm b/src/gui/macOS/fileproviderxpc_mac_utils.mm
@@ -75,16 +75,12 @@
                       completionHandler:^(NSFileProviderService *const service, NSError *const error) {
                 if (error != nil) {
                     qCWarning(lcFileProviderXPCUtils) << "Error getting file provider service" << error;
-                    dispatch_group_leave(group);
-                    return;
                 } else if (service == nil) {
                     qCWarning(lcFileProviderXPCUtils) << "Service is nil";
-                    dispatch_group_leave(group);
-                    return;
+                } else {
+                    [service retain];
+                    [fpServices addObject:@{acquiredService.name: acquiredService}];
                 }
-
-                [service retain];
-                [fpServices addObject:@{acquiredService.name: acquiredService}];
                 dispatch_group_leave(group);
             }];
             dispatch_group_wait(group, DISPATCH_TIME_FOREVER);