fix: use /enabled endpoint instead of app_api's ocs state check - #352
Merged
Merged
Conversation
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
1 task
marcelklehr
approved these changes
Sep 30, 2026
Member
|
fingers crossed this won't break things |
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enabledstate is inconsistent between app_api and the ex-app during initial setup.The
enabledflag in app_api is written to the DB before/initis called (i.e., before model download begins), while the ex-app's own/enabledendpoint is called only after/initcompletes. As a result, during the initial installation phase:nc.enabled_state, which hits/ocs/v1.php/apps/app_api/ex-app/state) can return a stale/incorrectenabledvalue.This is a race condition limited to only the app registration/installation part, once
/initfinishes, both sources report the same.🤖 AI (if applicable)