feat: Add a ContextChat provider #2271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
enh/context-chat
branch
from
d6a47a7 to
833c161
Compare
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
enh/context-chat
branch
from
833c161 to
647310a
Compare
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
enh/context-chat
branch
from
9a20cf4 to
12d00e6
Compare
|
Mmh, I'm getting hundreds of but context_chat:stats still shows: Perhaps because initially those bookmarks are all empty, after import and the crawl job still needs to fill them with content... 🤔 |
Signed-off-by: Marcel Klehr <[email protected]>
kyteinsky
reviewed
Mar 3, 2025
| * The ID of the provider | ||
| * | ||
| * @return string | ||
| * @since 1.1.0 |
Comment on lines
+125
to
+128
| if (count($items) < 25) { | ||
| continue; | ||
| } | ||
| $this->contentManager->submitContent($this->getAppId(), $items); |
There was a problem hiding this comment.
why the 25 item limit?
also, the submitContent should be outside the loop.
There was a problem hiding this comment.
ah sorry I misread it. The items array should still be cleared up when submitContent is called and checked once outside the loop.
submit content has a separate bg job that has a batch size of 20 so might be due to sheer no. of bookmarks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.