Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix - Use long type for lastGiven #14727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 25, 2025

  • Tests written, or not not needed

Library PR: nextcloud/android-library#1672
Issue: #14517

Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/use-long-for-last-given branch from fb7c368 to 71e4040 Compare April 2, 2025 09:15
Copy link

github-actions bot commented Apr 2, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14727.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented Apr 2, 2025

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code292292
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total500500

Copy link

github-actions bot commented Apr 2, 2025

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.13%. Comparing base (cbec4a1) to head (71e4040).

Files with missing lines Patch % Lines
...ties/data/activities/ActivitiesServiceApiImpl.java 0.00% 1 Missing ⚠️
...roid/ui/fragment/FileDetailActivitiesFragment.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14727      +/-   ##
============================================
- Coverage     24.20%   24.13%   -0.07%     
  Complexity     3329     3329              
============================================
  Files           697      697              
  Lines         51268    51268              
  Branches       6909     6909              
============================================
- Hits          12409    12375      -34     
- Misses        36926    36980      +54     
+ Partials       1933     1913      -20     
Files with missing lines Coverage Δ
...loud/android/ui/activities/ActivitiesActivity.java 0.00% <ø> (ø)
...oud/android/ui/activities/ActivitiesPresenter.java 0.00% <ø> (ø)
...es/data/activities/RemoteActivitiesRepository.java 0.00% <ø> (ø)
...ties/data/activities/ActivitiesServiceApiImpl.java 0.00% <0.00%> (ø)
...roid/ui/fragment/FileDetailActivitiesFragment.java 43.66% <0.00%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -10,7 +10,7 @@
*/
buildscript {
ext {
androidLibraryVersion ="766e7b818cace55031c010d949645b991dd340e0"
androidLibraryVersion ="f5b31bddd9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change library hash after merging library PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants