Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.8] SearchResultEntry: detect file results not from Files provider #766

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #762

Some providers like FullTextSearch give file results without the fileId attribute.
This refactor allows for that, otherwise they would crash the UnifiedSearch UI.

Signed-off-by: Álvaro Brey Vilas <[email protected]>
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-2.8PR
Warnings11
Errors00

SpotBugs (new)

Warning Type Number
Bad practice Warnings 14
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 7
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 40
Total 122

SpotBugs (stable-2.8)

Warning Type Number
Bad practice Warnings 14
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 7
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 40
Total 122

@AlvaroBrey AlvaroBrey merged commit dc02fc2 into stable-2.8 Nov 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the backport/762/stable-2.8 branch November 25, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants