Step1: GitHub(모듈 분리)#97
Merged
Merged
Conversation
wisemuji
requested changes
Aug 26, 2023
wisemuji
left a comment
wisemuji
left a comment
Member
There was a problem hiding this comment.
안녕하세요 성현님!
DM으로 안내드린것처럼 Step1에서의 모듈 분리는 이어지는 Step2, 3에서 기반이 되는 작업입니다.
이 PR에서 Step1, 2를 같이 리뷰하면 좋겠지만 미션 진행 상황 관리를 위해 여러 Step을 하나의 PR에서 작성하는 것은 허용되지 않는 걸로 알고 있습니다. 😢
Step2까지 구현해주셔서 번거로우시겠지만 Step1 변경사항만 남겨주시고, 이 PR이 머지되면 이어서 Step2를 올려주실 수 있을까요? Step1는 크게 특이사항이 없다면 별다른 Request Changes 없이 바로 머지하도록 할게요.
wisemuji
approved these changes
Aug 27, 2023
wisemuji
left a comment
wisemuji
left a comment
Member
There was a problem hiding this comment.
번거로우셨을텐데 감사합니다! 다음 PR 이어서 리뷰하겠습니다 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
프로그램 요구사항에 나온 내용이 제가 이해한바가 맞다면 너무 작은 단위인거 같아 2단계까지 병합하여 진행하였습니다.
좋은 피드백 많이 부탁드리겠습니다.