Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Changelog format was incorrect for PR 1114 and 1118 #1125

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: Changelog format was incorrect for PR 1114 and 1118 #1125

merged 1 commit into from
Oct 24, 2024

Conversation

zeitlerc
Copy link
Contributor

Description

I mistakenly formatted the changelog as if the code was released, but was actually supposed to follow this format: release-toolkit

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@zeitlerc zeitlerc requested a review from a team as a code owner October 24, 2024 18:12
@zeitlerc zeitlerc merged commit 0bdfec9 into main Oct 24, 2024
24 checks passed
@zeitlerc zeitlerc deleted the czeitler/changelog-fix-kube-1-31 branch October 24, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbudziwojskiNR dbudziwojskiNR dbudziwojskiNR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeitlerc @dbudziwojskiNR