Add vale to PR workflow #1780
Closed
Add vale to PR workflow #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs-website uses this linter in its CI. Since its introductino, we've needed to update change log entries after the fact. Let's add it to our PR workflow, in hopes that we can preemptively address its feedback.
SimpleCov Report
|
|
There's a lot of repo-specific config files that would need to stay in sync with the docs-website. I don't think this is ready to be added at this time. I opened an issue on the docs-website requesting a custom GitHub action with the styles, ini file, etc. for distribution to NR teams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs-website uses this linter in its CI.
Since its introduction, we've needed to update change log entries after the fact.
Let's add it to our PR workflow, in hopes that we can preemptively address its feedback.
https://vale.sh/