Add trace id ratio based sampler #1597

hmstepanek · 2025-12-03T00:29:58Z

Overview

Add trace id ratio based sampler.
Add support for partial granularity ratio = full gran ratio + partial gran ratio (when both set to ratio).

github-actions · 2025-12-03T00:33:11Z

✅MegaLinter analysis: Success

Descriptor	Linter	Files	Fixed	Elapsed time
✅ ACTION	actionlint	7		0.92s
✅ MARKDOWN	markdownlint	7	0	1.33s
✅ PYTHON	ruff	958	4	1.05s
✅ PYTHON	ruff-format	958	12	0.37s
✅ YAML	prettier	15	0	1.48s
✅ YAML	v8r	15		4.61s
✅ YAML	yamllint	15		0.68s

See detailed reports in MegaLinter artifacts

tests/agent_unittests/test_distributed_tracing_settings.py

codecov-commenter · 2025-12-03T01:03:38Z

Codecov Report

❌ Patch coverage is 64.86486% with 39 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop-hybrid-core-tracing@7dad3bb). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
newrelic/core/samplers/sampler_proxy.py	48.71%	13 Missing and 7 partials ⚠️
newrelic/core/config.py	75.00%	8 Missing and 3 partials ⚠️
newrelic/config.py	50.00%	8 Missing ⚠️

Additional details and impacted files

@@                      Coverage Diff                       @@
##             develop-hybrid-core-tracing    #1597   +/-   ##
==============================================================
  Coverage                               ?   79.90%           
==============================================================
  Files                                  ?      211           
  Lines                                  ?    24586           
  Branches                               ?     3902           
==============================================================
  Hits                                   ?    19646           
  Misses                                 ?     3564           
  Partials                               ?     1376

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lrafeei · 2025-12-04T03:26:12Z

newrelic/api/opentelemetry.py

        **kwargs,
    ):
-        return Tracer(resource=self._resource, instrumentation_library=instrumenting_module_name, *args, **kwargs)
+        return Tracer(resource=self._resource, instrumentation_library=instrumenting_module_name, **kwargs, *args)


Not sure if this was some regex gone wrong, but this should probably be changed back

Suggested change

return Tracer(resource=self._resource, instrumentation_library=instrumenting_module_name, **kwargs, *args)

return Tracer(resource=self._resource, instrumentation_library=instrumenting_module_name, *args, **kwargs)

Megalinter was complaining but my fix was incorrect. I've adjusted it so hopefully it makes more sense. The *args needs to be moved before resource=....

newrelic/core/config.py

* Add more formatting to custom event validatators * Add streamed responses to converse mock server * Add streaming fixtures for testing for converse * Rename other bedrock test files * Add tests for converse streaming * Instrument converse streaming * Move GeneratorProxy adjacent functions to mixin * Fix checking of supported models * Reorganize converse error tests * Port new converse botocore tests to aiobotocore * Instrument response streaming in aiobotocore converse * Fix suggestions from code review * Port in converse changes from strands PR * Delete commented code --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Add new Redis methods * Add RedisCluster methods to ignore list

Bumps the github_actions group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/checkout` from 5.0.1 to 6.0.0 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93cb6ef...1af3b93) Updates `astral-sh/setup-uv` from 7.1.3 to 7.1.4 - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@5a7eac6...1e862df) Updates `github/codeql-action` from 4.31.3 to 4.31.5 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@014f16e...fdbfb4d) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_actions - dependency-name: astral-sh/setup-uv dependency-version: 7.1.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions - dependency-name: github/codeql-action dependency-version: 4.31.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…Bedrock support (#1580) * Record the request message as the time the request started for LangChain. * Tracking the original timestamp of the request for input messages that are recorded as LlmChatCompletionMessage event types. * First pass at preserving LlmChatCompletionMessage timestamp for the request with Bedrock methods. * the `kwargs` was being mapped directly to the OpenAI client and having timestamp in there caused a problem. As a quick test, only add the request timestamp after the wrapped function has been invoked. * Moved the request timestamp to its own variable instead of part of kwargs. * OpenAI async request messages were not being assigned the correct timestamp. * Trying to improve the passing of the request timestamp through for Bedrock. * Passing too many parameters. * Set a default role on input/output messages within LangChain. * [MegaLinter] Apply linters fixes * Fix request_timestamp for LlmChatCompletionSummary table * Fix request_timestamp for LlmChatCompletionSummary table * [MegaLinter] Apply linters fixes * Bedrock Converse Streaming Support (#1565) * Add more formatting to custom event validatators * Add streamed responses to converse mock server * Add streaming fixtures for testing for converse * Rename other bedrock test files * Add tests for converse streaming * Instrument converse streaming * Move GeneratorProxy adjacent functions to mixin * Fix checking of supported models * Reorganize converse error tests * Port new converse botocore tests to aiobotocore * Instrument response streaming in aiobotocore converse * Fix suggestions from code review * Port in converse changes from strands PR * Delete commented code --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Bedrock Converse Streaming Support (#1565) * Add more formatting to custom event validatators * Add streamed responses to converse mock server * Add streaming fixtures for testing for converse * Rename other bedrock test files * Add tests for converse streaming * Instrument converse streaming * Move GeneratorProxy adjacent functions to mixin * Fix checking of supported models * Reorganize converse error tests * Port new converse botocore tests to aiobotocore * Instrument response streaming in aiobotocore converse * Fix suggestions from code review * Port in converse changes from strands PR * Delete commented code --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * [MegaLinter] Apply linters fixes * request_timestamp is now passed across different method * Fixed gemini model kwargs issue * [MegaLinter] Apply linters fixes * Update tests to validate presence of timestamp/ role and fix bugs in instrumentation. * Update aiobotocore instrumentation to receive request timestamp. --------- Co-authored-by: Josh Bonczkowski <[email protected]> Co-authored-by: sgoel-nr <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Timothy Pansino <[email protected]> Co-authored-by: Uma Annamalai <[email protected]>

Bumps the github_actions group with 4 updates: [actions/setup-python](https://github.com/actions/setup-python), [docker/metadata-action](https://github.com/docker/metadata-action), [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/setup-python` from 6.0.0 to 6.1.0 - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@e797f83...83679a8) Updates `docker/metadata-action` from 5.9.0 to 5.10.0 - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@318604b...c299e40) Updates `oxsecurity/megalinter` from 9.1.0 to 9.2.0 - [Release notes](https://github.com/oxsecurity/megalinter/releases) - [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md) - [Commits](oxsecurity/megalinter@62c799d...55a59b2) Updates `github/codeql-action` from 4.31.5 to 4.31.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@fdbfb4d...fe4161a) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions - dependency-name: docker/metadata-action dependency-version: 5.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions - dependency-name: oxsecurity/megalinter dependency-version: 9.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions - dependency-name: github/codeql-action dependency-version: 4.31.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Lalleh Rafeei <[email protected]>

…on-agent into add-ratio-sampler

hmstepanek requested a review from a team as a code owner December 3, 2025 00:29

hmstepanek changed the base branch from main to develop-hybrid-core-tracing December 3, 2025 00:30

hmstepanek force-pushed the add-ratio-sampler branch from 305214c to 6960c83 Compare December 3, 2025 00:31

hmstepanek commented Dec 3, 2025

View reviewed changes

tests/agent_unittests/test_distributed_tracing_settings.py Outdated Show resolved Hide resolved

hmstepanek force-pushed the add-ratio-sampler branch from afa94ba to 38a0151 Compare December 3, 2025 00:44

mergify bot added the tests-failing Tests failing in CI. label Dec 3, 2025

Add TraceIdRatioBasedSampler, config, & tests

d4321b2

hmstepanek force-pushed the add-ratio-sampler branch from 38a0151 to d4321b2 Compare December 3, 2025 01:15

lrafeei requested changes Dec 4, 2025

View reviewed changes

hmstepanek requested a review from lrafeei December 5, 2025 16:35

hmstepanek and others added 7 commits December 5, 2025 08:42

Fixup: put args before kwargs

135692a

Add new Redis methods (#1588)

a95aa00

* Add new Redis methods * Add RedisCluster methods to ignore list

Update newrelic/core/config.py

4eca5c7

Co-authored-by: Lalleh Rafeei <[email protected]>

hmstepanek force-pushed the add-ratio-sampler branch from c3a52cb to 4eca5c7 Compare December 5, 2025 16:42

mergify bot and others added 4 commits December 5, 2025 16:43

Merge branch 'develop-hybrid-core-tracing' into add-ratio-sampler

86de882

Fixup: unpacking args after kwargs

f32f77f

Merge branch 'add-ratio-sampler' of github.com:newrelic/newrelic-pyth…

e1ccaae

…on-agent into add-ratio-sampler

[MegaLinter] Apply linters fixes

ea771d8

lrafeei approved these changes Dec 8, 2025

View reviewed changes

hmstepanek merged commit 02dbb85 into develop-hybrid-core-tracing Dec 8, 2025
6 checks passed

hmstepanek deleted the add-ratio-sampler branch December 8, 2025 20:50

mergify bot removed the tests-failing Tests failing in CI. label Dec 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add trace id ratio based sampler #1597

Add trace id ratio based sampler #1597

Uh oh!

hmstepanek commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

codecov-commenter commented Dec 3, 2025

Uh oh!

lrafeei Dec 4, 2025

Uh oh!

hmstepanek Dec 5, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	return Tracer(resource=self._resource, instrumentation_library=instrumenting_module_name, *kwargs, args)
	return Tracer(resource=self._resource, instrumentation_library=instrumenting_module_name, args, *kwargs)

Add trace id ratio based sampler #1597

Add trace id ratio based sampler #1597

Uh oh!

Conversation

hmstepanek commented Dec 3, 2025

Overview

Uh oh!

github-actions bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅MegaLinter analysis: Success

Uh oh!

Uh oh!

codecov-commenter commented Dec 3, 2025

Codecov Report

Uh oh!

lrafeei Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

hmstepanek Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Dec 3, 2025 •

edited

Loading