-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: unified host fs store #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b485354 to
d6992c4
Compare
9826e99 to
22dca1e
Compare
d6992c4 to
f337555
Compare
22dca1e to
dcced0b
Compare
f337555 to
5f60349
Compare
dcced0b to
869c899
Compare
5f60349 to
26475f9
Compare
80905d0 to
6c96cd7
Compare
26475f9 to
19c3502
Compare
f1d3708 to
2f0c676
Compare
d7395b0 to
206ec88
Compare
7922857 to
41c8c13
Compare
bd490c5 to
2f3cd78
Compare
sigilioso
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
k8s-extended-e2e
Trigger extended k8s e2e on a PR
onhost
onhost-extended-e2e
Execution of on host e2e in the current branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Introduces a new trait
OpAMPDataStoreand makesK8sStoreand a newFileStoreimplement it for operations regarding OpAMP data (CRUD remote config, identifiers, read local config, etc).This way many of the structures that were originally dedicated for each implementation (
Storer,ConfigRepositoryXXX) and contained mostly identical behavior have been replaced with a unique implementation that is generic over the new trait.I tried to remove the intermediate traits (
InstanceIDStorer,InstanceIDGetter,ConfigRepository) so the cleanup was even more deep and was a net removal of code, but I encountered some unexpected issues, mainly thatOpAMPDataStoreis not easy to mock withmockalldue to it being highly generic, and also the fact that I would need to touch even more unrelated code to do that cleanup. So I leave this for a subsequent PR that might probably involve manual implementations ofOpAMPDataStoremocks. This PR could be merged separately from that change.Special notes for your reviewer
The commits called
replace XXXX with generic oneandremove redundant XXX implsdo the replacement and cleanup respectively, so they touch quite a bit of code (for example, many tests for the on host implementations were moved from thestorer/filemodules and placed infile_storeinstead, there might be redundant tests there!).Just a heads up in case you want to review them separately!
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
docsis aligned with the change.CONTRIBUTING.md.log level guidelines.