fix: update Tabs when clicking link on same page #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `useEffect` in Tabs.js was only running on page load, so linking to a tab on the same page wouldn't update the Tabs. rerunning the effect when `location.hash` changes fixes this
sunnyzanchi
requested review from
a team,
LizBaker and
tabathadelane
and removed request for
a team
✅ gatsby-theme-newrelic-develop deploy preview ready
|
LizBaker
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
useEffectin Tabs.js was only running on page load, so linking to a tab on the same page wouldn't update the Tabs. rerunning the effect whenlocation.hashchanges fixes this