Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough Component update #967

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Conversation

clarkmcadoo
Copy link
Contributor

@clarkmcadoo clarkmcadoo commented Dec 21, 2023

This updates the Walkthrough component to use css hover effects vs our onMouseOver and state setting logic to denote a visual difference.

Some style updates include making the circles larger, adding separation lines between steps, and increasing the spacing between elements.

Screenshot 2023-12-27 at 9 32 21 AM Screenshot 2023-12-27 at 9 32 50 AM

@clarkmcadoo clarkmcadoo requested review from a team, sunnyzanchi and tabathadelane and removed request for a team December 21, 2023 17:02
Copy link

gatsby-cloud bot commented Dec 21, 2023

✅ gatsby-theme-newrelic-develop deploy preview ready

sunnyzanchi
sunnyzanchi previously approved these changes Dec 21, 2023
Copy link
Contributor

@sunnyzanchi sunnyzanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

sunnyzanchi
sunnyzanchi previously approved these changes Jan 4, 2024
@tabathadelane
Copy link
Contributor

tabathadelane commented Jan 4, 2024

Tested in the docs site: The only nit i have is the spacing at the bottom of the black line on the left. It's a bit awkward on install pages or before a p tag. If it is followed by an element with a top margin/padding then it looks great.

Install page:
Screenshot 2024-01-04 at 4 44 01 PM

an element with a margin:
Screenshot 2024-01-04 at 5 00 25 PM

Copy link
Contributor

@tabathadelane tabathadelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. lgtm.

Screenshot 2024-01-05 at 2 45 10 PM

@clarkmcadoo clarkmcadoo merged commit 18e3a15 into develop Jan 5, 2024
6 checks passed
@clarkmcadoo clarkmcadoo deleted the clark/steps-design-update branch January 5, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants