-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to fetch license key from AWS Secrets Manager and SSM Parameter Store with caching #120
Open
gupta-yuvraj
wants to merge
41
commits into
newrelic:master
Choose a base branch
from
gp-nova:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shashank Murthy <[email protected]>
Signed-off-by: Shashank Murthy <[email protected]>
…-exposure CE-19060 addressing newrelic token exposure bug
…da update functionality
…-exposure CE-19060 Made changes to use terraform_data instead of null_resource with lambda update functionality
…-exposure CE-19060 addressing newrelic token exposure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces new functionality to support fetching New Relic license keys from multiple sources, including environment variables, AWS Systems Manager (SSM) Parameter Store, and AWS Secrets Manager. Additionally, it implements a caching mechanism to store the New Relic license key, preventing repeated fetches from Secrets Manager or SSM Parameter Store during every Lambda execution. The changes include updates to the Python source code, Terraform configuration, unit tests, and new policies for managing permissions and decryption.
Benefits
Additional Features
nr_license_key_source
to define the source of the license key (options:environment_var
,ssm
,secrets_manager
) with a default value ofenvironment_var
.enable_caching_for_license_key
to toggle caching for the New Relic license key in the Lambda function.Testing