Clean up code to follow code standards #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianHenryIE
reviewed
Dec 4, 2024
| @@ -37,6 +37,18 @@ | |||
| "require-dev": { | |||
| "newfold-labs/wp-php-standards": "^1.2.3" | |||
| }, | |||
| "scripts": { | |||
| "fix": [ | |||
| "vendor/bin/phpcbf --standard=phpcs.xml ." | |||
There was a problem hiding this comment.
Composer scripts don't need vendor/bin, it's naturally in $PATH for Composer.
BrianHenryIE
reviewed
Dec 4, 2024
| @@ -37,6 +37,18 @@ | |||
| "require-dev": { | |||
| "newfold-labs/wp-php-standards": "^1.2.3" | |||
| }, | |||
| "scripts": { | |||
| "fix": [ | |||
There was a problem hiding this comment.
Consider calling it cs-fix, per php-pds/composer-script-names, similarly below.
There was a problem hiding this comment.
I don't feel very strongly on this. I like the idea of conventions but I don't particularly like the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds
composer run lintandcomposer run testto run the code standards against our codebase & fixes up the current code to match it.Production
Development
Checklist
Further comments
There is definitely some more work that could be done here, along with some other cleanup and tests, but it's a good start.