Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing, undupe signatures in description. #1912

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

whatston3
Copy link
Contributor

About the PR

Uses TrySign when using a pen instead of TryStamp, removes duplicate signatures when reading the description for a piece of paper.

Why / Balance

Fixes issues with writing "default-component-stamp". Signature unduplication just for QOL.

How to test

  1. Spawn three pieces of paper, a pen, an APPROVED stamp, and a few crayons.
  2. Sign the first piece of paper with alt-click.
  3. Stamp the second piece of paper first and then click it with the pen to sign it.
  4. Sign the third piece of paper with all of the crayons and stamp it with the APPROVED stamp multiple times.
  5. Use the first two pieces of paper, they should both be signed with your character's name.
  6. Examine the third piece of paper. It should be signed by your character (listed once), and stamped by the APPROVED stamp (listed once).
  7. Open the third piece of paper. How could you have made such a mess (there should be multiple signatures, one for each crayon, and however many approved stamps you applied up to 10 max)

Media

An example sheet of paper that has been signed multiple times with crayons and stamped multiple times. The description only reads out once.
image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Using pens should now properly sign your name when used on previously stamped paper.
  • add: Paper descriptions now only list each unique signature/stamp.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Aug 31, 2024
@dvir001 dvir001 merged commit aa9a37f into new-frontiers-14:master Aug 31, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants