Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edison Power POI #1890

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Edison Power POI #1890

wants to merge 6 commits into from

Conversation

Cheackraze
Copy link
Member

@Cheackraze Cheackraze commented Aug 21, 2024

About the PR

This is just a new POI with a bit of puzzle with a handful of circuitboards, and a TEG. This is step one to introduce the "Matter Compressor" (name still work in progress) which may or may not make AME fuel, RCD ammo, and maybe some other shipyard-focused things out of pure energy.

This is a part of a larger project to implement more engineering focused gameplay. Original draft proposal below:

With the player market recently added, our overall goals to make most gameplay-important items include providing a source for AME fuel, and this finally provides us with an opportunity to start making some engineering gameplay on Frontier. Before this, engineering specific gameplay was minimal at best, with basically just some advanced atmos gameplay that isnt all that enjoyable.

There also hasnt been a need to harnass the various larger power engine options, which we can also incorporate into the machine as a massive power requirement to create the fuel. The machine itself will turn raw energy (in excess of 200-300kw of power to start, up to 1-4MW of power consumption) and a bit of steel, into AME jars at least 1 byproduct, possibly 2. The first planned byproduct is a hazardous gas output, Tritium, that will have to be piped and handled sufficiently to not clog the machine. The faster an engineer tries to make the machine work, the more tritium 'waste' will be output, and likely higher temps. While this could, in theory, be discarded, it also provides a potential avenue for either direct profit through capture, cooling, and selling, or it could potentially be used within the TEG loop to synthesize more efficient coolant (frezon), or to make for a more intense burn mixture, or both, depending on how much oxygen they are able to obtain (likely will not have any gas miners in the final version be warned).

This is only supposed to be the first step, albeit likely the most routine and important one, for introducing engineering type game loops into frontier. There have also been some good ideas for some additional optional activities engineers can participate in to occupy any downtime once they get the engines fine-tuned to their preferences.

Why / Balance

Engineering game play and

How to test

Load the map, warp to the power plant, look around.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@github-actions github-actions bot added Map-POI Map - POI No C# labels Aug 21, 2024
@Cheackraze Cheackraze changed the title Jar-Mo-Tron/Edison Power POI Edison Power POI Sep 5, 2024
@Cheackraze Cheackraze marked this pull request as ready for review September 5, 2024 17:15
@Cheackraze
Copy link
Member Author

Ready for review, but i'm headed out the door soon so I'll have to provide screenshots later.

@dvir001
Copy link
Contributor

dvir001 commented Sep 5, 2024

Keep in mind we moved all warp points and fax protos to be .yml based so forks can translate them, should be an easy yml swap on our side.

I think anomalousgeode also missing them

@Cheackraze
Copy link
Member Author

Cheackraze commented Sep 5, 2024 via email

@whatston3
Copy link
Contributor

Prototypes/_NF/PointsOfInterest/edison.yml:
26-34: If this is a spawnable station, consider making the jobs into overflow jobs (i.e. tuples of [-1, -1]), and adding some ships to the shipyard console (maybe an engineering-specific console with a restricted ship listing and maybe a transit ship included if things don't work out?) and a FuelVend (possible issues with an infinite, but expensive[??] supply of welding fuel?). If not, inherit from StandardFrontierOutpost.

Maps/_NF/POI/edison.yml:

  • L19705: Not LockerWallMaterialsFuelWeldingFilled? As far as I can tell, there's no actual mapped source of welding fuel at all on the station, which seems a bit odd considering it's an engineering POI. 400u shouldn't be too bad anyways.
  • No transit docks, no StationTransit component?
  • Curious, what's the reason to have a big atrium area?

Apart from the questions above, looks good on the first pass, will give this a more thorough look over when I can.

@Cheackraze
Copy link
Member Author

Its missing some of those things like station transit, round-start spawns, and actual shipyards because its not intended to be start point until theres actual engineering gameplay implemented. Until then its just a blank slate where people can hire through if need be.

Welding fuel was just a bit of an oversight and can be added. The atrium area is where the matter compressor will live eventually, with the space around it intended for possible pipes in the future. The singularity area and the supermatter area are a bit placeholder as well, pending code porting/singularity rewriting.

Copy link
Contributor

@GreaseMonk GreaseMonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor map points that need to be fixed before we merge:

There is a bank atm in the door here:
image
There is a double mapped pipe here:
image

May want to add fire locks to this door and on the other side of the station
image

SMES here is missing a HV cable (I moved the smes out of position)
image

@GreaseMonk
Copy link
Contributor

What is this flooring ?
It's not on the other side of the station
image

@GreaseMonk
Copy link
Contributor

GreaseMonk commented Sep 7, 2024

There is a double pipe mapped here (parts of map deleted to find piping errors):
image

@GreaseMonk
Copy link
Contributor

Is there supposed to be piping between radiator and passive vents ?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants