Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to support 2 subscription addresses #691

Merged
merged 17 commits into from
Jul 16, 2024

Conversation

eruizgar91
Copy link
Member

Description

Add a description of your changes here.

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@eruizgar91 eruizgar91 requested review from a team as code owners July 15, 2024 11:07
@@ -71,7 +70,8 @@ export class NvmApp {
private zeroDevSignerAccount: SmartAccountSigner<'custom', `0x${string}`> | undefined
public assetProviders: string[] = []
private loginCredentials: string | undefined
private subscriptionNFTContractAddress: string | undefined
private subscriptionNFTContractTimeAddress: string | undefined
private subscriptionNFTContractCredtisAddress: string | undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

eruizgar91 and others added 16 commits July 15, 2024 13:16
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@eruizgar91 eruizgar91 merged commit 15121e2 into main Jul 16, 2024
3 checks passed
@eruizgar91 eruizgar91 deleted the feat/update-nvmapp-two-subscriptions-addresses branch July 16, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants